Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/16621 )
Change subject: IMPALA-3816 Codegen perf critical loops in Sorter ...................................................................... Patch Set 7: Code-Review+1 (3 comments) lgtm, only nits http://gerrit.cloudera.org:8080/#/c/16621/7//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/16621/7//COMMIT_MSG@7 PS7, Line 7: IMPALA-3816 Codegen perf critical loops in Sorter nit: missing : http://gerrit.cloudera.org:8080/#/c/16621/7/be/src/runtime/sorter-internal.h File be/src/runtime/sorter-internal.h: http://gerrit.cloudera.org:8080/#/c/16621/7/be/src/runtime/sorter-internal.h@440 PS7, Line 440: attemp typo: attempt http://gerrit.cloudera.org:8080/#/c/16621/7/be/src/runtime/sorter.cc File be/src/runtime/sorter.cc: http://gerrit.cloudera.org:8080/#/c/16621/7/be/src/runtime/sorter.cc@35 PS7, Line 35: #include "runtime/fragment-state.h" The included headers are generally in the block above, sorted alphabetically. #include "common/names.h" is a special one that comes last, I am not sure why though :) -- To view, visit http://gerrit.cloudera.org:8080/16621 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie08137449d4a7b554ca8b8650260f8bd72e0a81b Gerrit-Change-Number: 16621 Gerrit-PatchSet: 7 Gerrit-Owner: Qifan Chen <qc...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Daniel Becker <daniel.bec...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Sahil Takiar <stak...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Mon, 26 Oct 2020 09:04:18 +0000 Gerrit-HasComments: Yes
