Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/16621 )
Change subject: IMPALA-3816 Codegen perf critical loops in Sorter ...................................................................... Patch Set 7: (5 comments) Great work! Aside from the nits, I wonder if 'CodegenFnPtr<Sorter::SortHelperFn> codegend_sort_helper_fn_' could be owned by Sorter::TupleSorter instead of SortPlanNode and PartialSortPlanNode. It seems that Sorter::TupleSorter is responsible for both codegening and calling it. http://gerrit.cloudera.org:8080/#/c/16621/7/be/src/exec/partial-sort-node.h File be/src/exec/partial-sort-node.h: http://gerrit.cloudera.org:8080/#/c/16621/7/be/src/exec/partial-sort-node.h@45 PS7, Line 45: TupelSorter Typo: TupleSorter. http://gerrit.cloudera.org:8080/#/c/16621/7/be/src/exec/partial-sort-node.cc File be/src/exec/partial-sort-node.cc: http://gerrit.cloudera.org:8080/#/c/16621/7/be/src/exec/partial-sort-node.cc@26 PS7, Line 26: #include "runtime/sorter-internal.h" Nit: This include should come before "util/runtime-profile-counters.h" because of the alphabetical order. http://gerrit.cloudera.org:8080/#/c/16621/7/be/src/exec/sort-node.cc File be/src/exec/sort-node.cc: http://gerrit.cloudera.org:8080/#/c/16621/7/be/src/exec/sort-node.cc@27 PS7, Line 27: #include "codegen/llvm-codegen.h" : #include "runtime/sorter-internal.h" Should be sorted alphabetically. http://gerrit.cloudera.org:8080/#/c/16621/7/be/src/runtime/sorter-internal.h File be/src/runtime/sorter-internal.h: http://gerrit.cloudera.org:8080/#/c/16621/7/be/src/runtime/sorter-internal.h@442 PS7, Line 442: GENERAL The implementation doesn't return Status("GENERAL") but Status("Sorter::TupleSorter::Codegen(): failed to finalize function"). The specific error message is better, so this doc comment should be updated. http://gerrit.cloudera.org:8080/#/c/16621/7/be/src/runtime/sorter.h File be/src/runtime/sorter.h: http://gerrit.cloudera.org:8080/#/c/16621/7/be/src/runtime/sorter.h@106 PS7, Line 106: code-gen Nit: we usually write it as 'codegen'. -- To view, visit http://gerrit.cloudera.org:8080/16621 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie08137449d4a7b554ca8b8650260f8bd72e0a81b Gerrit-Change-Number: 16621 Gerrit-PatchSet: 7 Gerrit-Owner: Qifan Chen <qc...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Daniel Becker <daniel.bec...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Sahil Takiar <stak...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Mon, 26 Oct 2020 10:53:09 +0000 Gerrit-HasComments: Yes
