wangsheng has posted comments on this change. ( http://gerrit.cloudera.org:8080/16599 )
Change subject: IMPALA-10288: Implement DESCRIBE HISTORY for Iceberg tables ...................................................................... Patch Set 4: Code-Review+1 (1 comment) Thanks for changes, Gabor. Apart from ' adding new reserved words' problem which Tim mentioned above, this patch LGTM. http://gerrit.cloudera.org:8080/#/c/16599/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/16599/1//COMMIT_MSG@14 PS1, Line 14: +----------------------------+---------------------+---------------------+---------------------+ : | creation_time | snapshot_id | parent_id | is_current_ancestor | : +----------------------------+---------------------+---------------------+---------------------+ : | 2020-10-13 14:01:07.234000 | 4400379706200951771 | NULL | TRUE | : | 2020-10-13 14:01:19.307000 | 4221472712544505868 | 4400379706200951771 | TRUE | : +----------------------------+---------------------+---------------------+---------------------+ > That should be a different query in my opinion. Here what I try to reproduc Thanks for explain, maybe we can support snapshot in another patch. -- To view, visit http://gerrit.cloudera.org:8080/16599 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I56a4b92c27e8e4a79109696cbae62735a00750e5 Gerrit-Change-Number: 16599 Gerrit-PatchSet: 4 Gerrit-Owner: Gabor Kaszab <gaborkas...@cloudera.com> Gerrit-Reviewer: Gabor Kaszab <gaborkas...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Reviewer: wangsheng <sky...@163.com> Gerrit-Comment-Date: Tue, 03 Nov 2020 02:22:54 +0000 Gerrit-HasComments: Yes
