Hello Zoltan Borok-Nagy, wangsheng, Tim Armstrong, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/16599
to look at the new patch set (#5).
Change subject: IMPALA-10288: Implement DESCRIBE HISTORY for Iceberg tables
......................................................................
IMPALA-10288: Implement DESCRIBE HISTORY for Iceberg tables
The DESCRIBE HISTORY works for Iceberg tables and displays the
snapshot history of the table.
An example output:
DESCRIBE HISTORY iceberg_multi_snapshots;
+----------------------------+---------------------+---------------------+---------------------+
| creation_time | snapshot_id | parent_id |
is_current_ancestor |
+----------------------------+---------------------+---------------------+---------------------+
| 2020-10-13 14:01:07.234000 | 4400379706200951771 | NULL | TRUE
|
| 2020-10-13 14:01:19.307000 | 4221472712544505868 | 4400379706200951771 | TRUE
|
+----------------------------+---------------------+---------------------+---------------------+
The purpose here was to have similar output with this new feature as
what SparkSql returns for "SELECT * from tablename.history".
See "History" section of
https://iceberg.apache.org/spark/#inspecting-tables
Testing:
- iceberg-negative.test was extended to check that DESCRIBE HISTORY
is not applicable for non-Iceberg tables.
- iceberg-table-history.test: Covers basic usage of DESCRIBE
HISTORY. Tests on tables created with Impala and also with Spark.
Change-Id: I56a4b92c27e8e4a79109696cbae62735a00750e5
---
M be/src/service/client-request-state.cc
M be/src/service/frontend.cc
M be/src/service/frontend.h
M common/thrift/Frontend.thrift
M fe/src/main/cup/sql-parser.cup
M fe/src/main/java/org/apache/impala/analysis/AnalysisContext.java
A fe/src/main/java/org/apache/impala/analysis/DescribeHistoryStmt.java
M fe/src/main/java/org/apache/impala/service/Frontend.java
M fe/src/main/java/org/apache/impala/service/JniFrontend.java
M fe/src/test/java/org/apache/impala/analysis/ParserTest.java
M testdata/data/README
A
testdata/data/iceberg_test/iceberg_multi_snapshots/data/2b4c7b0f52b60a94-5308a4d800000000_52928493_data.0.parq
A
testdata/data/iceberg_test/iceberg_multi_snapshots/data/97455b925ff67dcf-b56951ca00000000_1396743290_data.0.parq
A
testdata/data/iceberg_test/iceberg_multi_snapshots/metadata/559bbd83-47bf-420e-bd3b-0800ca89c81c-m0.avro
A
testdata/data/iceberg_test/iceberg_multi_snapshots/metadata/aa86e03c-db78-4ff2-afbd-905cbab0f4b7-m0.avro
A
testdata/data/iceberg_test/iceberg_multi_snapshots/metadata/snap-1034149846385246343-1-559bbd83-47bf-420e-bd3b-0800ca89c81c.avro
A
testdata/data/iceberg_test/iceberg_multi_snapshots/metadata/snap-1860064961840897739-1-aa86e03c-db78-4ff2-afbd-905cbab0f4b7.avro
A testdata/data/iceberg_test/iceberg_multi_snapshots/metadata/v1.metadata.json
A testdata/data/iceberg_test/iceberg_multi_snapshots/metadata/v2.metadata.json
A testdata/data/iceberg_test/iceberg_multi_snapshots/metadata/v3.metadata.json
A testdata/data/iceberg_test/iceberg_multi_snapshots/metadata/version-hint.text
M testdata/datasets/functional/functional_schema_template.sql
M testdata/datasets/functional/schema_constraints.csv
M testdata/workloads/functional-query/queries/QueryTest/iceberg-negative.test
A
testdata/workloads/functional-query/queries/QueryTest/iceberg-table-history.test
M tests/query_test/test_iceberg.py
26 files changed, 421 insertions(+), 13 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/99/16599/5
--
To view, visit http://gerrit.cloudera.org:8080/16599
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I56a4b92c27e8e4a79109696cbae62735a00750e5
Gerrit-Change-Number: 16599
Gerrit-PatchSet: 5
Gerrit-Owner: Gabor Kaszab <gaborkas...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <gaborkas...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <borokna...@cloudera.com>
Gerrit-Reviewer: wangsheng <sky...@163.com>
