Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/16599 )
Change subject: IMPALA-10288: Implement DESCRIBE HISTORY for Iceberg tables ...................................................................... Patch Set 5: (2 comments) http://gerrit.cloudera.org:8080/#/c/16599/5/be/src/service/client-request-state.cc File be/src/service/client-request-state.cc: http://gerrit.cloudera.org:8080/#/c/16599/5/be/src/service/client-request-state.cc@440 PS5, Line 440: ToStringFromUnixMicros Seems like this function doesn't take the TIMEZONE query option into account. I think you need to use TimestampValue::UtcFromUnixTimeMicros, then timestamp_value->UtcToLocal(timezone); http://gerrit.cloudera.org:8080/#/c/16599/5/fe/src/main/java/org/apache/impala/service/Frontend.java File fe/src/main/java/org/apache/impala/service/Frontend.java: http://gerrit.cloudera.org:8080/#/c/16599/5/fe/src/main/java/org/apache/impala/service/Frontend.java@1098 PS5, Line 1098: Set<Long> ancestorIds = Sets.newHashSet(SnapshotUtil.currentAncestors(table)) > It looks like this call can be placed before the start of the FOR loop. +1. Also the loadTable() call above. -- To view, visit http://gerrit.cloudera.org:8080/16599 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I56a4b92c27e8e4a79109696cbae62735a00750e5 Gerrit-Change-Number: 16599 Gerrit-PatchSet: 5 Gerrit-Owner: Gabor Kaszab <gaborkas...@cloudera.com> Gerrit-Reviewer: Gabor Kaszab <gaborkas...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Qifan Chen <qc...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Reviewer: wangsheng <sky...@163.com> Gerrit-Comment-Date: Thu, 12 Nov 2020 14:00:59 +0000 Gerrit-HasComments: Yes
