wangsheng has posted comments on this change. ( http://gerrit.cloudera.org:8080/16825 )
Change subject: IMPALA-10380: INSERT INTO identity-partitioned Iceberg tables ...................................................................... Patch Set 7: (3 comments) Thanks for new feature, Zoltan. Just some nits. http://gerrit.cloudera.org:8080/#/c/16825/4//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/16825/4//COMMIT_MSG@7 PS4, Line 7: identity-partitioned Iceberg tables Shall we use "Iceberg tables with only 'IDENTITY' partition" here? http://gerrit.cloudera.org:8080/#/c/16825/4/common/thrift/CatalogService.thrift File common/thrift/CatalogService.thrift: http://gerrit.cloudera.org:8080/#/c/16825/4/common/thrift/CatalogService.thrift@194 PS4, Line 194: tional string tab Maybe 'TIcebergOperationParam' here? These variable is not operation itself, just related to operation. http://gerrit.cloudera.org:8080/#/c/16825/4/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java File fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java: http://gerrit.cloudera.org:8080/#/c/16825/4/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@4655 PS4, Line 4655: ToCreate.isEmpty()) { It there any difference between 'partName' and partName.substring(0, partName.length())? -- To view, visit http://gerrit.cloudera.org:8080/16825 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If98797a2bfdc038d0467c8f83aadf1a12e1d69d4 Gerrit-Change-Number: 16825 Gerrit-PatchSet: 7 Gerrit-Owner: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Gabor Kaszab <gaborkas...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Reviewer: wangsheng <sky...@163.com> Gerrit-Comment-Date: Thu, 10 Dec 2020 12:41:23 +0000 Gerrit-HasComments: Yes
