Zoltan Borok-Nagy has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/16825 )

Change subject: IMPALA-10380: INSERT INTO Iceberg tables with 'IDENTITY' 
partitions only
......................................................................


Patch Set 8:

(3 comments)

Thanks for the comments, WangSheng!

http://gerrit.cloudera.org:8080/#/c/16825/4//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/16825/4//COMMIT_MSG@7
PS4, Line 7: Iceberg tables with 'IDENTITY' part
> Shall we use "Iceberg tables with only 'IDENTITY' partition" here?
Updated the title


http://gerrit.cloudera.org:8080/#/c/16825/4/common/thrift/CatalogService.thrift
File common/thrift/CatalogService.thrift:

http://gerrit.cloudera.org:8080/#/c/16825/4/common/thrift/CatalogService.thrift@194
PS4, Line 194: tional string tab
> Maybe 'TIcebergOperationParam' here? These variable is not operation itself
Done


http://gerrit.cloudera.org:8080/#/c/16825/4/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
File fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java:

http://gerrit.cloudera.org:8080/#/c/16825/4/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@4655
PS4, Line 4655: ToCreate.isEmpty()) {
> It there any difference between 'partName' and partName.substring(0, partNa
I think the only difference is that it creates an unnecessary copy of the 
String object. Thanks for spotting this, I also fixed it in my CR for 
IMPALA-10384: 
https://gerrit.cloudera.org/#/c/16850/5/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java

I'll remove these partition name related changes once that fix is merged.



--
To view, visit http://gerrit.cloudera.org:8080/16825
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If98797a2bfdc038d0467c8f83aadf1a12e1d69d4
Gerrit-Change-Number: 16825
Gerrit-PatchSet: 8
Gerrit-Owner: Zoltan Borok-Nagy <borokna...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <gaborkas...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <borokna...@cloudera.com>
Gerrit-Reviewer: wangsheng <sky...@163.com>
Gerrit-Comment-Date: Fri, 11 Dec 2020 14:44:24 +0000
Gerrit-HasComments: Yes

Reply via email to