Xianqing He has uploaded a new patch set (#10). ( http://gerrit.cloudera.org:8080/16911 )
Change subject: IMPALA-10413: fix impalad crashes when canceling the retrying query ...................................................................... IMPALA-10413: fix impalad crashes when canceling the retrying query The crash happens when canceling the retrying query. If the original query was unregistered while the new query was being created, it will call HandleRetryFailure to abort the new query. But the status is ok, so when calling Status::AddDetail impalad will crash. After the WaitAsync interface called and before the retry_request_state moved to retried_client_request_state_ , if abort the new retry query, retry_request_state need to call Finalize, otherwise the wait-thread will leak. In some cases like canceled the original query or closed the session we may not create the new query, so we also check whether the query is retried. Tests: Add test in tests/custom_cluster/test_query_retries.py and manually tested 100 times to make sure that there was no Impalad crash Change-Id: I4fd7228acd0a70d33859029052239f9b9f795e5d --- M be/src/runtime/query-driver.cc M be/src/service/client-request-state.h M be/src/service/impala-server.cc M tests/custom_cluster/test_query_retries.py 4 files changed, 58 insertions(+), 9 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/11/16911/10 -- To view, visit http://gerrit.cloudera.org:8080/16911 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I4fd7228acd0a70d33859029052239f9b9f795e5d Gerrit-Change-Number: 16911 Gerrit-PatchSet: 10 Gerrit-Owner: Xianqing He <hexianqing...@126.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com> Gerrit-Reviewer: Xianqing He <hexianqing...@126.com>
