Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/16911 )
Change subject: IMPALA-10413: fix impalad crashes when canceling the retrying query ...................................................................... Patch Set 10: (1 comment) http://gerrit.cloudera.org:8080/#/c/16911/8/be/src/runtime/query-driver.cc File be/src/runtime/query-driver.cc: http://gerrit.cloudera.org:8080/#/c/16911/8/be/src/runtime/query-driver.cc@273 PS8, Line 273: dleRetryFailure(&status, &error_msg, request_st > This waits to finish the retry query's wait-thread. A normal process waits Is thread wait_thread_ still running? If yes, what's the waiting point in ClientRequestState::WaitInternal()? If it's not running, we may add new simple function to reset wait_thread_, instead of calling ClientRequestState::Finalize(). -- To view, visit http://gerrit.cloudera.org:8080/16911 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4fd7228acd0a70d33859029052239f9b9f795e5d Gerrit-Change-Number: 16911 Gerrit-PatchSet: 10 Gerrit-Owner: Xianqing He <hexianqing...@126.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com> Gerrit-Reviewer: Xianqing He <hexianqing...@126.com> Gerrit-Comment-Date: Wed, 06 Jan 2021 23:54:11 +0000 Gerrit-HasComments: Yes
