Tim Armstrong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16214
Change subject: WIP: IMPALA-3816,IMPALA-4065: full TupleRowComparator codegen ...................................................................... WIP: IMPALA-3816,IMPALA-4065: full TupleRowComparator codegen This patch removes the indirection of codegened TupleRowComparator:: Compare() at its call sites in sorter and topn node. It's implemented by cloning and modifying all the functions between the codegened entry function and Compare(). The call site in SortedRunMerger is still indirect, but the indirection could be removed in the same way as this patch. Testing: * TODO: unit tests for SCC algo Perf: Tianyi said: "TPCH queries with a sort node are 2%-5% faster." TODO: run benchmarks Change-Id: I3c8f1c82cf6f932dd6aad8670c8cca2e53f80c84 --- M be/src/codegen/gen_ir_descriptions.py M be/src/codegen/llvm-codegen.cc M be/src/codegen/llvm-codegen.h M be/src/exec/topn-node.cc M be/src/runtime/sorted-run-merger.cc M be/src/runtime/sorter-internal.h M be/src/runtime/sorter-ir.cc M be/src/runtime/sorter.cc M be/src/runtime/sorter.h M be/src/util/tuple-row-compare.cc M be/src/util/tuple-row-compare.h A tests/custom_cluster/test_replace_tuple_row_compare.py 12 files changed, 354 insertions(+), 37 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/14/16214/1 -- To view, visit http://gerrit.cloudera.org:8080/16214 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I3c8f1c82cf6f932dd6aad8670c8cca2e53f80c84 Gerrit-Change-Number: 16214 Gerrit-PatchSet: 1 Gerrit-Owner: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Tianyi Wang <tw...@cloudera.com>
