Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16214 )
Change subject: WIP: IMPALA-3816,IMPALA-4065: full TupleRowComparator codegen ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/16214/1/be/src/util/tuple-row-compare.h File be/src/util/tuple-row-compare.h: http://gerrit.cloudera.org:8080/#/c/16214/1/be/src/util/tuple-row-compare.h@161 PS1, Line 161: // Call the interpreted implementation directly. If this function is cross-compiled, the line too long (92 > 90) http://gerrit.cloudera.org:8080/#/c/16214/1/be/src/util/tuple-row-compare.h@162 PS1, Line 162: // interpreted call will be replaced. If this function is being called from interpreted line too long (91 > 90) -- To view, visit http://gerrit.cloudera.org:8080/16214 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3c8f1c82cf6f932dd6aad8670c8cca2e53f80c84 Gerrit-Change-Number: 16214 Gerrit-PatchSet: 1 Gerrit-Owner: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Tianyi Wang <tw...@cloudera.com> Gerrit-Comment-Date: Mon, 25 Jan 2021 19:51:00 +0000 Gerrit-HasComments: Yes