Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/17038 )
Change subject: MPALA-10482: Select-star query on unrelative collection column of transactional table hits IllegalStateException ...................................................................... Patch Set 1: (4 comments) Thanks for the quick fix! http://gerrit.cloudera.org:8080/#/c/17038/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/17038/1//COMMIT_MSG@7 PS1, Line 7: MPALA nit: IMPALA http://gerrit.cloudera.org:8080/#/c/17038/1//COMMIT_MSG@25 PS1, Line 25: when doing star expansion I think we also need to ignore them when resolving slot refs. These cases are still not handled by this patch: create table pos_item_key_value_tbl ( pos bigint, item int, key string, value string, int_array array<int>, string_map map<string,string>) stored as orc tblproperties('transactional'='true'); select pos, item from pos_item_key_value_tbl.int_array; ERROR: AnalysisException: Column/field reference is ambiguous: 'pos' select key, value from pos_item_key_value_tbl.string_map; ERROR: AnalysisException: Column/field reference is ambiguous: 'key' http://gerrit.cloudera.org:8080/#/c/17038/1/fe/src/main/java/org/apache/impala/analysis/SelectStmt.java File fe/src/main/java/org/apache/impala/analysis/SelectStmt.java: http://gerrit.cloudera.org:8080/#/c/17038/1/fe/src/main/java/org/apache/impala/analysis/SelectStmt.java@130 PS1, Line 130: // Aliases of the hidden table refs added during query rewrite. E.g. full ACID scans can : // add auxiliary table refs to the FROM clause. We need to exclude these table refs : // during star expansion. > I am not too familiar with the full ACID rewrites, but my guess is that the Maybe the current name is ok. We may refactor the AcidRewriter and reuse it to support IMPALA-10484. http://gerrit.cloudera.org:8080/#/c/17038/1/testdata/workloads/functional-query/queries/QueryTest/nested-types-scanner-basic.test File testdata/workloads/functional-query/queries/QueryTest/nested-types-scanner-basic.test: http://gerrit.cloudera.org:8080/#/c/17038/1/testdata/workloads/functional-query/queries/QueryTest/nested-types-scanner-basic.test@317 PS1, Line 317: ==== > Can you add a bit more complex query? The idea is to include the same hidde +1 Could you also add some count(*) queries? -- To view, visit http://gerrit.cloudera.org:8080/17038 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8fc758d3c1e75c7066936d590aec8bff8d2b00b0 Gerrit-Change-Number: 17038 Gerrit-PatchSet: 1 Gerrit-Owner: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Comment-Date: Tue, 09 Feb 2021 02:04:29 +0000 Gerrit-HasComments: Yes
