Hello Qifan Chen, Tim Armstrong, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/17064
to look at the new patch set (#2).
Change subject: IMPALA-9745: Propagate source type when doing constant
propagation
......................................................................
IMPALA-9745: Propagate source type when doing constant propagation
When doing constant propagation the source type was not being
propagated to the target expression leading to an analysis failure.
The behavior is most easily reproducible with STRING to TIMESTAMP
conversion in the presence of other predicates.
This patch fixes this by adding an implicit cast if needed for such
cases.
Testing:
- Added planner test and ran other planner tests
- Added end-to-end test
Change-Id: Ic3853478945229440f733c256ea225639f9178ff
---
M fe/src/main/java/org/apache/impala/analysis/ConstantPredicateHandler.java
M
testdata/workloads/functional-planner/queries/PlannerTest/constant-propagation.test
M
testdata/workloads/functional-query/queries/QueryTest/range-constant-propagation.test
3 files changed, 38 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/64/17064/2
--
To view, visit http://gerrit.cloudera.org:8080/17064
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ic3853478945229440f733c256ea225639f9178ff
Gerrit-Change-Number: 17064
Gerrit-PatchSet: 2
Gerrit-Owner: Aman Sinha <amsi...@cloudera.com>
Gerrit-Reviewer: Aman Sinha <amsi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com>
Gerrit-Reviewer: Qifan Chen <qc...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com>
