Aman Sinha has posted comments on this change. ( http://gerrit.cloudera.org:8080/17064 )
Change subject: IMPALA-9745: Propagate source type when doing constant propagation ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/17064/2/fe/src/main/java/org/apache/impala/analysis/ConstantPredicateHandler.java File fe/src/main/java/org/apache/impala/analysis/ConstantPredicateHandler.java: http://gerrit.cloudera.org:8080/#/c/17064/2/fe/src/main/java/org/apache/impala/analysis/ConstantPredicateHandler.java@186 PS2, Line 186: Expr expr = source.getType().equals(target.getType()) ? > Should this use !....equals() instead of != Yes. I also flipped it to use just equals instead of not-equals logic. -- To view, visit http://gerrit.cloudera.org:8080/17064 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic3853478945229440f733c256ea225639f9178ff Gerrit-Change-Number: 17064 Gerrit-PatchSet: 3 Gerrit-Owner: Aman Sinha <amsi...@cloudera.com> Gerrit-Reviewer: Aman Sinha <amsi...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Qifan Chen <qc...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Fri, 12 Feb 2021 21:59:46 +0000 Gerrit-HasComments: Yes
