Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/17081 )
Change subject: IMPALA-10512: ALTER TABLE ADD PARTITION should bump the write id for ACID tables ...................................................................... Patch Set 1: Code-Review+1 (3 comments) I am ok with raising this to +2 if this is critical, but I would prefer to think about this topic more deeply. http://gerrit.cloudera.org:8080/#/c/17081/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/17081/1//COMMIT_MSG@9 PS1, Line 9: should bump the write id Don't we also need a lock in this case? For example currently this can happen at the same time as a TRUNCATE. http://gerrit.cloudera.org:8080/#/c/17081/1//COMMIT_MSG@9 PS1, Line 9: ADD PARTITION Don't we need to do the same in DROP PARTITION? http://gerrit.cloudera.org:8080/#/c/17081/1/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java File fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java: http://gerrit.cloudera.org:8080/#/c/17081/1/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@3188 PS1, Line 3188: allocateTableWriteId What happens if allocateTableWriteId throws a TransactionException? -- To view, visit http://gerrit.cloudera.org:8080/17081 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iad247008b7c206db00516326c1447bd00a9b34bd Gerrit-Change-Number: 17081 Gerrit-PatchSet: 1 Gerrit-Owner: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Gabor Kaszab <gaborkas...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Comment-Date: Thu, 18 Feb 2021 16:16:20 +0000 Gerrit-HasComments: Yes
