Zoltan Borok-Nagy has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/17081 )

Change subject: IMPALA-10512: ALTER TABLE ADD PARTITION should bump the write 
id for ACID tables
......................................................................


Patch Set 1:

(2 comments)

Thanks for the comments

http://gerrit.cloudera.org:8080/#/c/17081/1/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
File fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java:

http://gerrit.cloudera.org:8080/#/c/17081/1/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@3187
PS1, Line 3187:     long txnId = MetastoreShim.openTransaction(msClient);
> I think tools like Hive replication depend on the fact that these events ha
I see, I've modified code accordingly.


http://gerrit.cloudera.org:8080/#/c/17081/2/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
File fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java:

http://gerrit.cloudera.org:8080/#/c/17081/2/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@3194
PS2, Line 3194:    * Returns the list of Partition objects from 'aList' that 
cannot be found in 'bList'.
              :    * Partition objects are distinguished by partition values 
only.
              :    */
              :   private List<Partition> computeDifference(List<Partition> 
aList,
              :       List<Partition> bList) {
              :     Set<List<String>> bSet = Sets.newHashSet();
              :     for (Partition b: bList) bSet.add(b.getValues());
              :
              :     List<Partition> diffList = Lists.newArrayList();
              :     for (Partition a: aList) {
              :       if (!bSet.contains(a.getValues())) diffList.add(a);
              :     }
              :     ret
> nice to habve: there could be a function for this, e.g. cleanupFailedTransa
I switched to using utility class Transaction.



--
To view, visit http://gerrit.cloudera.org:8080/17081
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iad247008b7c206db00516326c1447bd00a9b34bd
Gerrit-Change-Number: 17081
Gerrit-PatchSet: 1
Gerrit-Owner: Zoltan Borok-Nagy <borokna...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <gaborkas...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com>
Gerrit-Reviewer: Vihang Karajgaonkar <vih...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <borokna...@cloudera.com>
Gerrit-Comment-Date: Thu, 25 Feb 2021 11:54:34 +0000
Gerrit-HasComments: Yes

Reply via email to