Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/17095 )
Change subject: IMPALA-9767: Do not clean up filter while PublishFilter is ongoing ...................................................................... Patch Set 2: (10 comments) Thanks Fang-Yu. I'm also rewording a bit. http://gerrit.cloudera.org:8080/#/c/17095/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/17095/1//COMMIT_MSG@7 PS1, Line 7: clean u > nit: clean up Done http://gerrit.cloudera.org:8080/#/c/17095/1//COMMIT_MSG@9 PS1, Line 9: have been occurren > nit: have been occurrences Done http://gerrit.cloudera.org:8080/#/c/17095/1//COMMIT_MSG@10 PS1, Line 10: filt > nit: a Bloom Done http://gerrit.cloudera.org:8080/#/c/17095/1//COMMIT_MSG@10 PS1, Line 10: publish > nit: publishing Done http://gerrit.cloudera.org:8080/#/c/17095/1//COMMIT_MSG@11 PS1, Line 11: is still sending the aggrega > nit: the coordinator is still sending the aggregated filter via KRPC Done http://gerrit.cloudera.org:8080/#/c/17095/1//COMMIT_MSG@12 PS1, Line 12: nup rout > nit: decouples Done http://gerrit.cloudera.org:8080/#/c/17095/1//COMMIT_MSG@12 PS1, Line 12: This > nit: removes Done http://gerrit.cloudera.org:8080/#/c/17095/1//COMMIT_MSG@13 PS1, Line 13: > nit: a separate Done http://gerrit.cloudera.org:8080/#/c/17095/1//COMMIT_MSG@14 PS1, Line 14: to a s > nit: asserts Done http://gerrit.cloudera.org:8080/#/c/17095/1//COMMIT_MSG@15 PS1, Line 15: :Relea > nit: the filter Done -- To view, visit http://gerrit.cloudera.org:8080/17095 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1c408bdedab83c4b9249e2c0c493cb0f894a3d08 Gerrit-Change-Number: 17095 Gerrit-PatchSet: 2 Gerrit-Owner: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Reviewer: Fang-Yu Rao <fangyu....@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Comment-Date: Mon, 22 Feb 2021 01:39:53 +0000 Gerrit-HasComments: Yes
