Fang-Yu Rao has posted comments on this change. ( http://gerrit.cloudera.org:8080/17095 )
Change subject: IMPALA-9767: Do not clean up filter while PublishFilter is ongoing ...................................................................... Patch Set 2: Code-Review+1 (1 comment) Thanks Riza! I only have a very minor comment on the commit message and do not have any more suggestion. http://gerrit.cloudera.org:8080/#/c/17095/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/17095/2//COMMIT_MSG@10 PS2, Line 10: a Bloom filter is : cleaning up nit: Maybe it would be a bit clearer if we change it to the following. the memory consumed by an aggregated Bloom filter has been released -- To view, visit http://gerrit.cloudera.org:8080/17095 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1c408bdedab83c4b9249e2c0c493cb0f894a3d08 Gerrit-Change-Number: 17095 Gerrit-PatchSet: 2 Gerrit-Owner: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Reviewer: Fang-Yu Rao <fangyu....@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Comment-Date: Mon, 22 Feb 2021 04:39:46 +0000 Gerrit-HasComments: Yes
