Thomas Tauber-Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/17111 )
Change subject: IMPALA-10532 TestOverlapMinMaxFilters.test_overlap_min_max_filters seems flaky ...................................................................... Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/17111/4/testdata/workloads/functional-query/queries/QueryTest/overlap_min_max_filters.test File testdata/workloads/functional-query/queries/QueryTest/overlap_min_max_filters.test: http://gerrit.cloudera.org:8080/#/c/17111/4/testdata/workloads/functional-query/queries/QueryTest/overlap_min_max_filters.test@34 PS4, Line 34: 80 > It was based on several error reports where the total number of pages filte Well, the scanner should wait at least RUNTIME_FILTER_WAIT_TIME_MS before starting, so assuming that's set high enough to ensure they arrive before it starts (which is what we've always relied on in other similar runtime filter tests) I think the total sum would be deterministic. Relying on that still leaves the possibility that the test is flaky in unusually slow environments, of course, but it has the nice property that when the test does run correctly we've ensured that the filter is applied correctly (eg. by making this a lower bound instead of a precise count there's a certain class of bugs where the filters are being misapplied and not filtering things that should be filtered that the test would not catch anymore). So, it might be nice to just increase RUNTIME_FILTER_WAIT_TIME_MS instead of what you've done here. On the other hand, we've already increased that value a few times in the past due to this sort of flakiness, and we can't just keep increasing it forever. I'll leave it up to you. -- To view, visit http://gerrit.cloudera.org:8080/17111 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I93940a104bfb2d68cb1d41d7e303348190fd5972 Gerrit-Change-Number: 17111 Gerrit-PatchSet: 4 Gerrit-Owner: Qifan Chen <qc...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Qifan Chen <qc...@cloudera.com> Gerrit-Reviewer: Thomas Tauber-Marshall <tmarsh...@cloudera.com> Gerrit-Comment-Date: Tue, 23 Feb 2021 20:51:13 +0000 Gerrit-HasComments: Yes
