Thomas Tauber-Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/17111 )
Change subject: IMPALA-10532 TestOverlapMinMaxFilters.test_overlap_min_max_filters seems flaky ...................................................................... Patch Set 5: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/17111/5/testdata/workloads/functional-query/queries/QueryTest/overlap_min_max_filters.test File testdata/workloads/functional-query/queries/QueryTest/overlap_min_max_filters.test: http://gerrit.cloudera.org:8080/#/c/17111/5/testdata/workloads/functional-query/queries/QueryTest/overlap_min_max_filters.test@9 PS5, Line 9: CREATE TABLE tpch_parquet.lineitem_orderkey_only(l_orderkey bigint) I see there are already other instances like this in this file, so I guess its fine to leave as is, but I wanted to note that I think a better way of doing this rather than creating the table in the tpch_parquet database (which potentially leaves it in a weird state if one of the test cases before the "drop table" below fails), would be to use the 'unique_database' functionality and create the table there, which would guarantee that its always dropped even if an error is encountered. -- To view, visit http://gerrit.cloudera.org:8080/17111 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I93940a104bfb2d68cb1d41d7e303348190fd5972 Gerrit-Change-Number: 17111 Gerrit-PatchSet: 5 Gerrit-Owner: Qifan Chen <qc...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Qifan Chen <qc...@cloudera.com> Gerrit-Reviewer: Thomas Tauber-Marshall <tmarsh...@cloudera.com> Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com> Gerrit-Comment-Date: Thu, 25 Feb 2021 21:21:25 +0000 Gerrit-HasComments: Yes
