Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/17194 )
Change subject: IMPALA-10590: Introduce admission service heartbeat mechanism ...................................................................... Patch Set 1: (5 comments) http://gerrit.cloudera.org:8080/#/c/17194/1/be/src/scheduling/admission-control-service.cc File be/src/scheduling/admission-control-service.cc: http://gerrit.cloudera.org:8080/#/c/17194/1/be/src/scheduling/admission-control-service.cc@265 PS1, Line 265: AdmissionHeartbeat what happens when a coord dies? does the AC service detect that and remove all queries for that host? if yes, we should also remove the entry for that coord in running_queries_ otherwise we might end up with empty map entries whenever a coord restarts. http://gerrit.cloudera.org:8080/#/c/17194/1/be/src/scheduling/admission-controller.h File be/src/scheduling/admission-controller.h: http://gerrit.cloudera.org:8080/#/c/17194/1/be/src/scheduling/admission-controller.h@835 PS1, Line 835: Map from host id to maps from nit: Map from host id to a map of query id http://gerrit.cloudera.org:8080/#/c/17194/1/be/src/scheduling/admission-controller.cc File be/src/scheduling/admission-controller.cc: http://gerrit.cloudera.org:8080/#/c/17194/1/be/src/scheduling/admission-controller.cc@1361 PS1, Line 1361: / In the context of the admission control service, this may happen, eg. if a : // ReleaseQuery rpc is reported as failed to the coordinator but actually ends up : // arriving much later, so only log at WARNING level. can you document the remote client's behavior for failed RPCs in its class comment http://gerrit.cloudera.org:8080/#/c/17194/1/be/src/scheduling/admission-controller.cc@1364 PS1, Line 1364: LOG(WARNING) << "Unable to find resources to release for query " nit: maybe add to the log message that it might have already been released. http://gerrit.cloudera.org:8080/#/c/17194/1/be/src/scheduling/admission-controller.cc@1397 PS1, Line 1397: LOG(DFATAL) should this be a warning now too? -- To view, visit http://gerrit.cloudera.org:8080/17194 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia528d92268cea487ada20b476935a81166f5ad34 Gerrit-Change-Number: 17194 Gerrit-PatchSet: 1 Gerrit-Owner: Thomas Tauber-Marshall <tmarsh...@cloudera.com> Gerrit-Reviewer: Bikramjeet Vig <bikramjeet....@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com> Gerrit-Comment-Date: Thu, 18 Mar 2021 16:34:33 +0000 Gerrit-HasComments: Yes
