Thomas Tauber-Marshall has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/17194 )

Change subject: IMPALA-10590: Introduce admission service heartbeat mechanism
......................................................................


Patch Set 2:

(5 comments)

http://gerrit.cloudera.org:8080/#/c/17194/1/be/src/scheduling/admission-control-service.cc
File be/src/scheduling/admission-control-service.cc:

http://gerrit.cloudera.org:8080/#/c/17194/1/be/src/scheduling/admission-control-service.cc@265
PS1, Line 265: tate_map_.Get(req-
> what happens when a coord dies? does the AC service detect that and remove
Coming in another patch: https://gerrit.cloudera.org/#/c/17209/


http://gerrit.cloudera.org:8080/#/c/17194/1/be/src/scheduling/admission-controller.h
File be/src/scheduling/admission-controller.h:

http://gerrit.cloudera.org:8080/#/c/17194/1/be/src/scheduling/admission-controller.h@835
PS1, Line 835:
> nit: Map from host id to a map of query id
Done


http://gerrit.cloudera.org:8080/#/c/17194/1/be/src/scheduling/admission-controller.cc
File be/src/scheduling/admission-controller.cc:

http://gerrit.cloudera.org:8080/#/c/17194/1/be/src/scheduling/admission-controller.cc@1361
PS1, Line 1361: (it == host_it->second.end()) {
              :       // In the context of the admission control service, this 
may happen, eg. if a
              :       // ReleaseQuery rpc is reported as failed to the coor
> can you document the remote client's behavior for failed RPCs in its class
Done


http://gerrit.cloudera.org:8080/#/c/17194/1/be/src/scheduling/admission-controller.cc@1364
PS1, Line 1364:       // arriving much later, so only log at WARNING level.
> nit: maybe add to the log message that it might have already been released.
Done


http://gerrit.cloudera.org:8080/#/c/17194/1/be/src/scheduling/admission-controller.cc@1397
PS1, Line 1397: to it = hos
> should this be a warning now too?
Coming in a follow up patch: https://gerrit.cloudera.org/#/c/17208/



--
To view, visit http://gerrit.cloudera.org:8080/17194
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia528d92268cea487ada20b476935a81166f5ad34
Gerrit-Change-Number: 17194
Gerrit-PatchSet: 2
Gerrit-Owner: Thomas Tauber-Marshall <tmarsh...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bikramjeet....@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tmarsh...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Fri, 19 Mar 2021 19:01:09 +0000
Gerrit-HasComments: Yes

Reply via email to