Tamas Mate has posted comments on this change. ( http://gerrit.cloudera.org:8080/17170 )
Change subject: IMPALA-7825: Upgrade Thrift version to 0.11.0 ...................................................................... Patch Set 10: (2 comments) Hi Csaba, thanks for the change, added a question and found a nit. http://gerrit.cloudera.org:8080/#/c/17170/10/bin/impala-config.sh File bin/impala-config.sh: http://gerrit.cloudera.org:8080/#/c/17170/10/bin/impala-config.sh@158 PS10, Line 158: IMPALA_THRIFT11_VERSION Is this variable needed in the future? http://gerrit.cloudera.org:8080/#/c/17170/10/shell/ext-py/thrift_sasl-0.4.2/setup.py File shell/ext-py/thrift_sasl-0.4.2/setup.py: http://gerrit.cloudera.org:8080/#/c/17170/10/shell/ext-py/thrift_sasl-0.4.2/setup.py@34 PS10, Line 34: nit: whitespace -- To view, visit http://gerrit.cloudera.org:8080/17170 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idd13f177b4f7acc07872ea6399035aa180ef6ab6 Gerrit-Change-Number: 17170 Gerrit-PatchSet: 10 Gerrit-Owner: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Tamas Mate <tm...@cloudera.com> Gerrit-Comment-Date: Tue, 20 Apr 2021 12:56:28 +0000 Gerrit-HasComments: Yes
