Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/17455 )
Change subject: add OSS/JindoFS support, impala with this change will create a dedicate thread pool for this kind of target. By default 16 threads would be craeted ...................................................................... Patch Set 2: (1 comment) Hi Yong Yang, thanks for your contribution to Impala! I think the code looks good but the commit message needs some tidying. http://gerrit.cloudera.org:8080/#/c/17455/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/17455/2//COMMIT_MSG@7 PS2, Line 7: add OSS/JindoFS support, impala with this change will create a dedicate thread pool for this kind of target. Can you please rewrite the commit messages according the guidelines in https://cwiki.apache.org/confluence/display/IMPALA/Contributing+to+Impala ? Importantly the first line of the commit message should start with "IMPALA-10696:". A good way to see what commit message should look like is to read other contributors commit messages. Also, it might be useful to include a very short description to OSS/JindoFS, or a link to a good introduction to this technology. -- To view, visit http://gerrit.cloudera.org:8080/17455 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4643105628f3860e3145c85d9ed205fe20291add Gerrit-Change-Number: 17455 Gerrit-PatchSet: 2 Gerrit-Owner: Yong Yang <yong.su...@163.com> Gerrit-Reviewer: Andrew Sherman <asher...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Yong Yang <yong.su...@163.com> Gerrit-Comment-Date: Mon, 17 May 2021 16:07:20 +0000 Gerrit-HasComments: Yes
