Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/17455 )
Change subject: IMPALA-10695: add dedicated thread pool for OSS/JindoFS. ...................................................................... Patch Set 5: (5 comments) Thanks for the changes, I think this is close to being done. http://gerrit.cloudera.org:8080/#/c/17455/5//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/17455/5//COMMIT_MSG@7 PS5, Line 7: IMPALA-10695: add dedicated thread pool for OSS/JindoFS. Please can you reformat the commit message so that the maximum line length is 72 chars. http://gerrit.cloudera.org:8080/#/c/17455/5//COMMIT_MSG@9 PS5, Line 9: OSS is the object store in ali cloud, just like s3a, and jindofs is a gateway based on Ali cloud object store. I think it would be clearer to say "Alibaba" rather than "Ali". http://gerrit.cloudera.org:8080/#/c/17455/5//COMMIT_MSG@10 PS5, Line 10: The following is about the JindoFS, https://github.com/aliyun/alibabacloud-jindofs. Thanks for the link. For me that page is hard to understand (due to my limitations), maybe add an additional link for English-only speakers like https://www.alibabacloud.com/blog/introducing-jindofs-a-high-performance-data-lake-storage-solution_595600 http://gerrit.cloudera.org:8080/#/c/17455/5//COMMIT_MSG@11 PS5, Line 11: If ali object store would be treated as local disk without this change, the query performance is not good. This change would create a dedicate queue for this kind of target, and improved the OSS scan performance. Nit: "dedicated" is clearer. http://gerrit.cloudera.org:8080/#/c/17455/5//COMMIT_MSG@13 PS5, Line 13: Please add a note New flags: - num_oss_io_threads: Number of OSS/JindoFS I/O threads. Defaults to 16. -- To view, visit http://gerrit.cloudera.org:8080/17455 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4643105628f3860e3145c85d9ed205fe20291add Gerrit-Change-Number: 17455 Gerrit-PatchSet: 5 Gerrit-Owner: Yong Yang <yong.su...@163.com> Gerrit-Reviewer: Andrew Sherman <asher...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Yong Yang <yong.su...@163.com> Gerrit-Comment-Date: Tue, 18 May 2021 16:52:04 +0000 Gerrit-HasComments: Yes
