Qifan Chen has posted comments on this change. ( http://gerrit.cloudera.org:8080/17502 )
Change subject: IMPALA-10197 (Part 2): Add KUDU_REPLICA_SELECTION query option ...................................................................... Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/17502/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/17502/3//COMMIT_MSG@16 PS3, Line 16: make nit. makes http://gerrit.cloudera.org:8080/#/c/17502/3/testdata/workloads/functional-planner/queries/PlannerTest/kudu-replica-selection-closest-replica.test File testdata/workloads/functional-planner/queries/PlannerTest/kudu-replica-selection-closest-replica.test: http://gerrit.cloudera.org:8080/#/c/17502/3/testdata/workloads/functional-planner/queries/PlannerTest/kudu-replica-selection-closest-replica.test@a38 PS3, Line 38: : : : : : : : : : : : : I wonder if the serial plan part can be retained if options.setNum_nodes(1) is provided in the setup. The rational is that there must be at least one LEADER. I agree testing in a non-deterministic is difficult for non-serial plan. When #hosts is so, its value must be filtered out. -- To view, visit http://gerrit.cloudera.org:8080/17502 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3e23667c06c273a261e03de3d81fc7ee1f6b0682 Gerrit-Change-Number: 17502 Gerrit-PatchSet: 3 Gerrit-Owner: Wenzhe Zhou <wz...@cloudera.com> Gerrit-Reviewer: Grant Henke <granthe...@apache.org> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Qifan Chen <qc...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Comment-Date: Tue, 25 May 2021 13:45:27 +0000 Gerrit-HasComments: Yes
