Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/17502 )
Change subject: IMPALA-10197 (Part 2): Add KUDU_REPLICA_SELECTION query option ...................................................................... Patch Set 4: Code-Review+2 (1 comment) The fix looks good to me. I think we just want to verify the LEADER-only anotation of the plan. So it's ok to not have the distributed plan. http://gerrit.cloudera.org:8080/#/c/17502/4/fe/src/test/java/org/apache/impala/planner/PlannerTest.java File fe/src/test/java/org/apache/impala/planner/PlannerTest.java: http://gerrit.cloudera.org:8080/#/c/17502/4/fe/src/test/java/org/apache/impala/planner/PlannerTest.java@694 PS4, Line 694: options.setNum_nodes(1); Do we still need to set num_nodes=1 if we don't check the distributed plans? -- To view, visit http://gerrit.cloudera.org:8080/17502 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3e23667c06c273a261e03de3d81fc7ee1f6b0682 Gerrit-Change-Number: 17502 Gerrit-PatchSet: 4 Gerrit-Owner: Wenzhe Zhou <wz...@cloudera.com> Gerrit-Reviewer: Grant Henke <granthe...@apache.org> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Qifan Chen <qc...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com> Gerrit-Comment-Date: Wed, 26 May 2021 03:39:44 +0000 Gerrit-HasComments: Yes