Vihang Karajgaonkar has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/17542 )

Change subject: IMPALA-10187: Event processing fails on multiple events + DROP 
TABLE
......................................................................


Patch Set 1:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/17542/1/fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java
File fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java:

http://gerrit.cloudera.org:8080/#/c/17542/1/fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java@2740
PS1, Line 2740: reloadTableIfExists
> I think the problem is not limited to tables but rather create, drop events
I discussed with Zoltan offline and we agreed that since 
https://gerrit.cloudera.org/#/c/17308/ is fairly complex and and harder to 
backport it would be good to get this patch in.


http://gerrit.cloudera.org:8080/#/c/17542/1/tests/custom_cluster/test_event_processing.py
File tests/custom_cluster/test_event_processing.py:

http://gerrit.cloudera.org:8080/#/c/17542/1/tests/custom_cluster/test_event_processing.py@220
PS1, Line 220: tmp
Setting table directory to /tmp can lead to flakiness if the drop table 
statements below removes contents of /tmp. Can you set it to a dir within /tmp 
instead and change the table to external?


http://gerrit.cloudera.org:8080/#/c/17542/1/tests/custom_cluster/test_event_processing.py@224
PS1, Line 224: tbl_name = "bar"
             :       self.run_stmt_in_hive("""
             :           drop table if exists {db}.{tbl};
             :           create table {db}.{tbl} (id int);
             :           insert into {db}.{tbl} 
values(2);""".format(db=db_name, tbl=tbl_name))
             :       EventProcessorUtils.wait_for_event_processing(self, 
event_proc_timeout)
             :       data = self.execute_scalar("select * from %s.%s" % 
(db_name, tbl_name))
             :       assert data == '2'
Or you can simply do the following
assert EventProcessorUtils.get_event_processor_status() == "ACTIVE"



--
To view, visit http://gerrit.cloudera.org:8080/17542
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2bd72247293d830063f66eecf9e4ba69a439a605
Gerrit-Change-Number: 17542
Gerrit-PatchSet: 1
Gerrit-Owner: Zoltan Borok-Nagy <borokna...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com>
Gerrit-Reviewer: Vihang Karajgaonkar <vih...@cloudera.com>
Gerrit-Comment-Date: Fri, 04 Jun 2021 18:52:14 +0000
Gerrit-HasComments: Yes

Reply via email to