Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/17542 )
Change subject: IMPALA-10187: Event processing fails on multiple events + DROP TABLE ...................................................................... Patch Set 2: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/17542/2/fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java File fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java: http://gerrit.cloudera.org:8080/#/c/17542/2/fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java@2738 PS2, Line 2738: DatabaseNotFoundException Wouldn't it be more intuitive if both exceptions were handled at the same level? This functions is called only here: https://github.com/apache/impala/blob/b28da054f3595bb92873433211438306fc22fbc7/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java#L563 -- To view, visit http://gerrit.cloudera.org:8080/17542 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2bd72247293d830063f66eecf9e4ba69a439a605 Gerrit-Change-Number: 17542 Gerrit-PatchSet: 2 Gerrit-Owner: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Vihang Karajgaonkar <vih...@cloudera.com> Gerrit-Reviewer: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Comment-Date: Mon, 07 Jun 2021 15:59:50 +0000 Gerrit-HasComments: Yes
