Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/17570 )
Change subject: IMPALA-10711: Allow customizing startup's filesystem check ...................................................................... Patch Set 4: Code-Review+1 (6 comments) http://gerrit.cloudera.org:8080/#/c/17570/4/fe/src/main/java/org/apache/impala/service/JniFrontend.java File fe/src/main/java/org/apache/impala/service/JniFrontend.java: http://gerrit.cloudera.org:8080/#/c/17570/4/fe/src/main/java/org/apache/impala/service/JniFrontend.java@903 PS4, Line 903: BackendConfig.INSTANCE.getStartupFilesystemCheckDirectories(); nit: +2 indentation http://gerrit.cloudera.org:8080/#/c/17570/4/fe/src/main/java/org/apache/impala/service/JniFrontend.java@916 PS4, Line 916: path_string + " does not exist."; nit: +2 indentation http://gerrit.cloudera.org:8080/#/c/17570/4/fe/src/main/java/org/apache/impala/service/JniFrontend.java@920 PS4, Line 920: path_string + " is not a directory."; nit: +2 indentation http://gerrit.cloudera.org:8080/#/c/17570/4/fe/src/main/java/org/apache/impala/service/JniFrontend.java@926 PS4, Line 926: path_string + ". Error was: \n" + e.getMessage(); nit: +2 indentation http://gerrit.cloudera.org:8080/#/c/17570/4/fe/src/main/java/org/apache/impala/service/JniFrontend.java@929 PS4, Line 929: ". Error was: \n" + e.getMessage(); nit: +2 indentation http://gerrit.cloudera.org:8080/#/c/17570/4/tests/custom_cluster/test_startup_filesystem_checks.py File tests/custom_cluster/test_startup_filesystem_checks.py: http://gerrit.cloudera.org:8080/#/c/17570/4/tests/custom_cluster/test_startup_filesystem_checks.py@112 PS4, Line 112: # The core dumps expected to be generated by this test should be cleaned up : possible_cores = find_all_files('*core*') : post_test_cores = set([f for f in possible_cores if is_core_dump(f)]) : : for f in (post_test_cores - self.pre_test_cores): : LOG.info("Cleaned up {core} created by tests".format(core=f)) : os.remove(f) Another similar test uses a simpler method IMO: https://github.com/apache/impala/blob/b28da054f3595bb92873433211438306fc22fbc7/tests/custom_cluster/test_query_event_hooks.py#L86 It simply creates a tmpdir and writes the coredumps there. -- To view, visit http://gerrit.cloudera.org:8080/17570 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I68e6802424f16002c90a37b3ae2490721525e58d Gerrit-Change-Number: 17570 Gerrit-PatchSet: 4 Gerrit-Owner: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Comment-Date: Thu, 10 Jun 2021 11:10:54 +0000 Gerrit-HasComments: Yes
