Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/17570 )
Change subject: IMPALA-10711: Allow customizing startup's filesystem check ...................................................................... Patch Set 5: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/17570/4/tests/custom_cluster/test_startup_filesystem_checks.py File tests/custom_cluster/test_startup_filesystem_checks.py: http://gerrit.cloudera.org:8080/#/c/17570/4/tests/custom_cluster/test_startup_filesystem_checks.py@112 PS4, Line 112: # The core dumps expected to be generated by this test should be cleaned up : possible_cores = find_all_files('*core*') : post_test_cores = set([f for f in possible_cores if is_core_dump(f)]) : : for f in (post_test_cores - self.pre_test_cores): : LOG.info("Cleaned up {core} created by tests".format(core=f)) : os.remove(f) > I brought back the minidump_path flag in case any minidumps get written. Thanks for the explanation! I didn't realize that Impala can generate a core dump if it doesn't start up. I agree with the plan in IMPALA-10148 -- To view, visit http://gerrit.cloudera.org:8080/17570 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I68e6802424f16002c90a37b3ae2490721525e58d Gerrit-Change-Number: 17570 Gerrit-PatchSet: 5 Gerrit-Owner: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Comment-Date: Thu, 10 Jun 2021 20:37:33 +0000 Gerrit-HasComments: Yes
