Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/17553 )
Change subject: IMPALA-10557: Support Kudu's multi-row transaction ...................................................................... Patch Set 14: (3 comments) http://gerrit.cloudera.org:8080/#/c/17553/13/be/src/exec/kudu-table-sink.cc File be/src/exec/kudu-table-sink.cc: http://gerrit.cloudera.org:8080/#/c/17553/13/be/src/exec/kudu-table-sink.cc@330 PS13, Line 330: Retrun nit: Return http://gerrit.cloudera.org:8080/#/c/17553/13/be/src/service/client-request-state.cc File be/src/service/client-request-state.cc: http://gerrit.cloudera.org:8080/#/c/17553/13/be/src/service/client-request-state.cc@955 PS13, Line 955: !status.ok() nit: maybe wrap in UNLIKELY? http://gerrit.cloudera.org:8080/#/c/17553/14/tests/custom_cluster/test_kudu.py File tests/custom_cluster/test_kudu.py: http://gerrit.cloudera.org:8080/#/c/17553/14/tests/custom_cluster/test_kudu.py@388 PS14, Line 388: # Verify that multi-row transaction is not opened for "update". : self.execute_query(self._update_query.format(table_name)) : cursor.execute(self._row_num_query.format(table_name)) : assert cursor.fetchall() == [(103,)] : # Verify that multi-row transaction is not opened for "upsert". : self.execute_query(self._upsert_query.format(table_name)) : cursor.execute(self._row_num_query.format(table_name)) : assert cursor.fetchall() == [(103,)] : # Delete all rows from Kudu table. Also verify that multi-row transaction is not : # opened for "delete". : self.execute_query(self._delete_query.format(table_name)) I'm hesitant to allow this case here -- it seems odd to proceed with the operations if they cannot be performed transactionally. While potentially inconvenient, having to switch between true and false for ENABLE_KUDU_TRANSACTION, it seems less surprising to have a query fail and for the entire transaction to be aborted if we're performing any update/delete/upserts operations that fail when ENABLE_KUDU_TRANSACTION=true. What do you think? -- To view, visit http://gerrit.cloudera.org:8080/17553 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I876ada48991afdff5d61b5d6a0417571aba7cb34 Gerrit-Change-Number: 17553 Gerrit-PatchSet: 14 Gerrit-Owner: Wenzhe Zhou <wz...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Bikramjeet Vig <bikramjeet....@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Qifan Chen <qc...@cloudera.com> Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com> Gerrit-Comment-Date: Tue, 15 Jun 2021 00:09:51 +0000 Gerrit-HasComments: Yes
