Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/17553 )
Change subject: IMPALA-10557: Support Kudu's multi-row transaction ...................................................................... Patch Set 17: (3 comments) http://gerrit.cloudera.org:8080/#/c/17553/17/tests/custom_cluster/test_kudu.py File tests/custom_cluster/test_kudu.py: http://gerrit.cloudera.org:8080/#/c/17553/17/tests/custom_cluster/test_kudu.py@386 PS17, Line 386: self.execute_query(self._delete_query.format(table_name)) > Why don't we need to move this below L390? Wouldn't the delete queries fail Remove this line after set ENABLE_KUDU_TRANSACTION=false http://gerrit.cloudera.org:8080/#/c/17553/17/tests/custom_cluster/test_kudu.py@417 PS17, Line 417: self.execute_query(self._update_query.format(table_name)) : self.execute_query(self._upsert_query.format(table_name)) : self.execute_query(self._delete_query.format(table_name)) > Can we have three separate try/catches? Otherwise we'll just fail at the fi It does not help with separate try/catch. The test throw assertion when getting first error. http://gerrit.cloudera.org:8080/#/c/17553/17/tests/custom_cluster/test_kudu.py@422 PS17, Line 422: assert "Not implemented" in str(e) > nit: consider re-checking the number of rows after failing the above operat previous line already throw assertion, remove this line. -- To view, visit http://gerrit.cloudera.org:8080/17553 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I876ada48991afdff5d61b5d6a0417571aba7cb34 Gerrit-Change-Number: 17553 Gerrit-PatchSet: 17 Gerrit-Owner: Wenzhe Zhou <wz...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Bikramjeet Vig <bikramjeet....@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Qifan Chen <qc...@cloudera.com> Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com> Gerrit-Comment-Date: Tue, 15 Jun 2021 23:54:38 +0000 Gerrit-HasComments: Yes
