Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/17553 )
Change subject: IMPALA-10557: Support Kudu's multi-row transaction ...................................................................... Patch Set 18: (1 comment) http://gerrit.cloudera.org:8080/#/c/17553/14/tests/custom_cluster/test_kudu.py File tests/custom_cluster/test_kudu.py: http://gerrit.cloudera.org:8080/#/c/17553/14/tests/custom_cluster/test_kudu.py@388 PS14, Line 388: self.execute_query(self._delete_query.format(table_name)) : self.execute_query(self._insert_3_rows_query.format(table_name)) : cursor.execute(self._row_num_query.format(table_name)) : assert cursor.fetchall() == [(3,)] : self.execute_query(self._insert_select_query.format(table_name)) : cursor.execute(self._row_num_query.format(table_name)) : assert cursor.fetchall() == [(103,)] : : @pytest.mark.execute_serially : @SkipIfKudu.no_hybrid_clock : def test_kudu_txn_not_implemented(self, cursor, unique_data > Thank you for updating this! Ah seems I wasn't clear about my concern here. It seems like surprising behavior that a user specifies ENABLE_KUDU_TRANSACTION=true, but under the hood, we don't perform a transaction for the update/delete/upsert operations. As a user, I'd expect that if my query could not be performed transactionally, the query should fail -- is that not the expectation of Impala users? -- To view, visit http://gerrit.cloudera.org:8080/17553 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I876ada48991afdff5d61b5d6a0417571aba7cb34 Gerrit-Change-Number: 17553 Gerrit-PatchSet: 18 Gerrit-Owner: Wenzhe Zhou <wz...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Bikramjeet Vig <bikramjeet....@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Qifan Chen <qc...@cloudera.com> Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com> Gerrit-Comment-Date: Wed, 16 Jun 2021 00:44:29 +0000 Gerrit-HasComments: Yes
