Vihang Karajgaonkar has posted comments on this change. ( http://gerrit.cloudera.org:8080/17713 )
Change subject: IMPALA-10817: Share metastoreHmsDDL lock b/w CatalogOpExecutor and Catalog metastore server ...................................................................... Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/17713/4//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/17713/4//COMMIT_MSG@23 PS4, Line 23: Relying on existing tests since it is a small refactoring I don't think there are any existing tests which exercise these DDLs concurrently from catalogOp as well as CatalogMetastore interfaces. Can you please add them to confirm that there are no missing edge cases? -- To view, visit http://gerrit.cloudera.org:8080/17713 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I60d4f3a49eb843fa8640cd21d623fd8dda770001 Gerrit-Change-Number: 17713 Gerrit-PatchSet: 4 Gerrit-Owner: Sourabh Goyal <soura...@cloudera.com> Gerrit-Reviewer: Anonymous Coward <kis...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Sourabh Goyal <soura...@cloudera.com> Gerrit-Reviewer: Vihang Karajgaonkar <vih...@cloudera.com> Gerrit-Reviewer: Yu-Wen Lai <yu-wen....@cloudera.com> Gerrit-Comment-Date: Wed, 28 Jul 2021 19:50:03 +0000 Gerrit-HasComments: Yes
