Vihang Karajgaonkar has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/17713 )
Change subject: IMPALA-10817: Share metastoreHmsDDL lock b/w CatalogOpExecutor and Catalog metastore server ...................................................................... IMPALA-10817: Share metastoreHmsDDL lock b/w CatalogOpExecutor and Catalog metastore server Currently, when doing create/drop table/db from catalogD, catalogOpExecutor (via Impala Shell) and metastore server (via HS2) acquires lock on their own lock objects to prevent concurrent create/drop operations in HMS. But that does not prevent these concurrent operations across CatalogOpExecutor and Metastore server. For example currently a user can perform create/drop HMS operation from Impala shell and catalog metastore server concurrently which is not the desired behavior. This patch unifies the lock object which will be acquired by both catalogOpExecutor as well as metastore server. Testing: Relying on existing tests since it is a small refactoring. Change-Id: I60d4f3a49eb843fa8640cd21d623fd8dda770001 Reviewed-on: http://gerrit.cloudera.org:8080/17713 Tested-by: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Reviewed-by: <kis...@cloudera.com> Reviewed-by: Vihang Karajgaonkar <vih...@cloudera.com> --- M fe/src/main/java/org/apache/impala/catalog/metastore/MetastoreServiceHandler.java M fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java 2 files changed, 202 insertions(+), 137 deletions(-) Approvals: Impala Public Jenkins: Verified kis...@cloudera.com: Looks good to me, but someone else must approve Vihang Karajgaonkar: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/17713 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I60d4f3a49eb843fa8640cd21d623fd8dda770001 Gerrit-Change-Number: 17713 Gerrit-PatchSet: 6 Gerrit-Owner: Sourabh Goyal <soura...@cloudera.com> Gerrit-Reviewer: Anonymous Coward <kis...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Sourabh Goyal <soura...@cloudera.com> Gerrit-Reviewer: Vihang Karajgaonkar <vih...@cloudera.com> Gerrit-Reviewer: Yu-Wen Lai <yu-wen....@cloudera.com>
