Vihang Karajgaonkar has posted comments on this change. ( http://gerrit.cloudera.org:8080/17576 )
Change subject: IMPALA-10746: Drop table/db from catalog cache when drop table/db HMS apis are accessed from catalog's metastore server. ...................................................................... Patch Set 17: (3 comments) The patch looks good to me. Thanks for making all the suggested changes. I just have some code styling nits. I can merge the patch once they are addressed. http://gerrit.cloudera.org:8080/#/c/17576/17/fe/src/main/java/org/apache/impala/catalog/metastore/MetastoreServiceHandler.java File fe/src/main/java/org/apache/impala/catalog/metastore/MetastoreServiceHandler.java: http://gerrit.cloudera.org:8080/#/c/17576/17/fe/src/main/java/org/apache/impala/catalog/metastore/MetastoreServiceHandler.java@2967 PS17, Line 2967: ) : throws MetaExceptio nit, can go in the same line above. I would suggest you to have your IDE set up with the code-style format from https://github.com/google/styleguide/blob/gh-pages/intellij-java-google-style.xml which works well for me. http://gerrit.cloudera.org:8080/#/c/17576/18/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java File fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java: http://gerrit.cloudera.org:8080/#/c/17576/18/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@861 PS18, Line 861: this pls update the java doc http://gerrit.cloudera.org:8080/#/c/17576/18/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@865 PS18, Line 865: if (catalogDb this can go into the above line now. -- To view, visit http://gerrit.cloudera.org:8080/17576 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic2e2ad2630e2028b8ad26a6272ee766b27e0935c Gerrit-Change-Number: 17576 Gerrit-PatchSet: 17 Gerrit-Owner: Sourabh Goyal <soura...@cloudera.com> Gerrit-Reviewer: Anonymous Coward <kis...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Sourabh Goyal <soura...@cloudera.com> Gerrit-Reviewer: Vihang Karajgaonkar <vih...@cloudera.com> Gerrit-Reviewer: Yu-Wen Lai <yu-wen....@cloudera.com> Gerrit-Comment-Date: Mon, 09 Aug 2021 23:59:44 +0000 Gerrit-HasComments: Yes
