Sourabh Goyal has posted comments on this change. ( http://gerrit.cloudera.org:8080/17576 )
Change subject: IMPALA-10746: Drop table/db from catalog cache when drop table/db HMS apis are accessed from catalog's metastore server. ...................................................................... Patch Set 19: (2 comments) http://gerrit.cloudera.org:8080/#/c/17576/19/fe/src/main/java/org/apache/impala/catalog/metastore/MetastoreServiceHandler.java File fe/src/main/java/org/apache/impala/catalog/metastore/MetastoreServiceHandler.java: http://gerrit.cloudera.org:8080/#/c/17576/19/fe/src/main/java/org/apache/impala/catalog/metastore/MetastoreServiceHandler.java@2966 PS19, Line 2966: LOG.debug("Invalidating non transactional table {} due to HMS api {}", > Why are you changing metastore to HMS ? Metastore seems to be more generic. There was no specific reason. Will revert back to using Metastore http://gerrit.cloudera.org:8080/#/c/17576/19/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java File fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java: http://gerrit.cloudera.org:8080/#/c/17576/19/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@2348 PS19, Line 2348: eventType.equals(DropDatabaseEvent.DROP_DATABASE_EVENT_TYPE) || > How about Truncate table ? Alter_Table event is generated for truncate_table. As of now, we just invalidate the table and not add it to deleteEventLog -- To view, visit http://gerrit.cloudera.org:8080/17576 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic2e2ad2630e2028b8ad26a6272ee766b27e0935c Gerrit-Change-Number: 17576 Gerrit-PatchSet: 19 Gerrit-Owner: Sourabh Goyal <soura...@cloudera.com> Gerrit-Reviewer: Anonymous Coward <kis...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Sourabh Goyal <soura...@cloudera.com> Gerrit-Reviewer: Vihang Karajgaonkar <vih...@cloudera.com> Gerrit-Reviewer: Yu-Wen Lai <yu-wen....@cloudera.com> Gerrit-Comment-Date: Tue, 10 Aug 2021 19:38:00 +0000 Gerrit-HasComments: Yes
