Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/17759 )
Change subject: IMPALA-10846: Skip Authentication for connection with trusted auth header ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/17759/1/be/src/util/webserver.cc File be/src/util/webserver.cc: http://gerrit.cloudera.org:8080/#/c/17759/1/be/src/util/webserver.cc@907 PS1, Line 907: bool Webserver::HandleTrustedAuthHeader( : struct sq_connection* connection, struct sq_request_info* request_info) { : string err_msg; : if (!GetUsernameFromAuthHeader(connection, request_info, err_msg)) { : LOG(ERROR) << "Found trusted auth header but " << err_msg; : return false; : } : return true; : } > nit: you can just get rid of HandleTrustedAuthHeader if you are only callin Will remove HandleTrustedAuthHeader(). -- To view, visit http://gerrit.cloudera.org:8080/17759 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7103012bc9cf9dfdc9c184af3a281526d8127a31 Gerrit-Change-Number: 17759 Gerrit-PatchSet: 2 Gerrit-Owner: Wenzhe Zhou <wz...@cloudera.com> Gerrit-Reviewer: Andrew Sherman <asher...@cloudera.com> Gerrit-Reviewer: Bikramjeet Vig <bikramjeet....@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com> Gerrit-Comment-Date: Tue, 10 Aug 2021 01:18:56 +0000 Gerrit-HasComments: Yes
