Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/17759 )
Change subject: IMPALA-10846: Skip Authentication for connection with trusted auth header ...................................................................... Patch Set 3: (1 comment) I talked to Bikram offline and we both had the same concern so I think it is worth adding to our doc on the flag. http://gerrit.cloudera.org:8080/#/c/17759/3/be/src/rpc/authentication.cc File be/src/rpc/authentication.cc: http://gerrit.cloudera.org:8080/#/c/17759/3/be/src/rpc/authentication.cc@144 PS3, Line 144: "authentication again."); >From a practical point of view it seems that to use a trusted header you would >need some part of your system to remove the trusted header from any requests >from outside the system. Do you agree? If so can you add a note to that >effect here. -- To view, visit http://gerrit.cloudera.org:8080/17759 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7103012bc9cf9dfdc9c184af3a281526d8127a31 Gerrit-Change-Number: 17759 Gerrit-PatchSet: 3 Gerrit-Owner: Wenzhe Zhou <wz...@cloudera.com> Gerrit-Reviewer: Andrew Sherman <asher...@cloudera.com> Gerrit-Reviewer: Bikramjeet Vig <bikramjeet....@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com> Gerrit-Comment-Date: Tue, 10 Aug 2021 22:28:20 +0000 Gerrit-HasComments: Yes
