Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/17794 )
Change subject: IMPALA-10822: Allow multiple group returns for LDAP Search ...................................................................... Patch Set 4: (3 comments) http://gerrit.cloudera.org:8080/#/c/17794/4/be/src/util/ldap-util.cc File be/src/util/ldap-util.cc: http://gerrit.cloudera.org:8080/#/c/17794/4/be/src/util/ldap-util.cc@a204 PS4, Line 204: : Maybe we could keep this logic with nr_of_entries >= 1. This would lead to a clearer warning in the log if no entries are found, for example if all the messages as references. http://gerrit.cloudera.org:8080/#/c/17794/4/fe/src/test/java/org/apache/impala/customcluster/LdapSearchBindImpalaShellTest.java File fe/src/test/java/org/apache/impala/customcluster/LdapSearchBindImpalaShellTest.java: http://gerrit.cloudera.org:8080/#/c/17794/4/fe/src/test/java/org/apache/impala/customcluster/LdapSearchBindImpalaShellTest.java@71 PS4, Line 71: TEST_USER_GROUP This comment looks stale. http://gerrit.cloudera.org:8080/#/c/17794/4/fe/src/test/java/org/apache/impala/customcluster/LdapSearchBindImpalaShellTest.java@75 PS4, Line 75: {1} Shouldn't we create a new test instead of changing this one? So that both one and the two group case would be tested. -- To view, visit http://gerrit.cloudera.org:8080/17794 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I27eaf717985207e36d4fa47a2af757d06544474e Gerrit-Change-Number: 17794 Gerrit-PatchSet: 4 Gerrit-Owner: Tamas Mate <tm...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Daniel Becker <daniel.bec...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Comment-Date: Tue, 24 Aug 2021 11:15:04 +0000 Gerrit-HasComments: Yes
