Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/17794 )
Change subject: IMPALA-10822: Allow multiple group returns for LDAP Search ...................................................................... Patch Set 6: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/17794/4/be/src/util/ldap-util.cc File be/src/util/ldap-util.cc: http://gerrit.cloudera.org:8080/#/c/17794/4/be/src/util/ldap-util.cc@a204 PS4, Line 204: : > Ah, I see, I think that is not needed here, if anything would happen with t Yes, ldap_first_message will handle it, it just that we'll log a less informative error message in some cases, e.g. when LdapSimpleBind::CheckGroupMembership calls LdapSearchObject. But it's ok like this, +2 from my side. -- To view, visit http://gerrit.cloudera.org:8080/17794 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I27eaf717985207e36d4fa47a2af757d06544474e Gerrit-Change-Number: 17794 Gerrit-PatchSet: 6 Gerrit-Owner: Tamas Mate <tm...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Daniel Becker <daniel.bec...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Tamas Mate <tm...@cloudera.com> Gerrit-Comment-Date: Fri, 27 Aug 2021 14:08:01 +0000 Gerrit-HasComments: Yes
