Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/15403 )
Change subject: IMPALA-6505: Min-Max predicate push down in ORC scanner ...................................................................... Patch Set 6: (5 comments) Fixed a clang-tidy error Addressed test issues caused by ORC-971. http://gerrit.cloudera.org:8080/#/c/15403/5/fe/src/main/java/org/apache/impala/planner/HdfsScanNode.java File fe/src/main/java/org/apache/impala/planner/HdfsScanNode.java: http://gerrit.cloudera.org:8080/#/c/15403/5/fe/src/main/java/org/apache/impala/planner/HdfsScanNode.java@1842 PS5, Line 1842: if (hasParquet(fileFormats_) && fileFormats_.contains(HdfsFileFormat.ORC) > I thought Impala does not support a table with mixed parquet/orc formats. Yeah, each partition can have its own format. But it's rarely used. Docs: https://impala.apache.org/docs/build/html/topics/impala_partitioning.html#ariaid-title12 https://docs.cloudera.com/documentation/enterprise/latest/topics/impala_partitioning.html#mixed_format_partitions http://gerrit.cloudera.org:8080/#/c/15403/5/tests/query_test/test_orc_stats.py File tests/query_test/test_orc_stats.py: http://gerrit.cloudera.org:8080/#/c/15403/5/tests/query_test/test_orc_stats.py@18 PS5, Line 18: from tests.common.test_vector import ImpalaTestDimension > flake8: F401 'pytest' imported but unused Done http://gerrit.cloudera.org:8080/#/c/15403/5/tests/query_test/test_orc_stats.py@23 PS5, Line 23: > flake8: E265 block comment should start with '# ' Done http://gerrit.cloudera.org:8080/#/c/15403/5/tests/query_test/test_orc_stats.py@26 PS5, Line 26: This suite tests runtime optimizations based on ORC statistics. > flake8: E302 expected 2 blank lines, found 1 Done http://gerrit.cloudera.org:8080/#/c/15403/5/tests/query_test/test_orc_stats.py@47 PS5, Line 47: > flake8: W391 blank line at end of file Done -- To view, visit http://gerrit.cloudera.org:8080/15403 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I136622413db21e0941d238ab6aeea901a6464845 Gerrit-Change-Number: 15403 Gerrit-PatchSet: 6 Gerrit-Owner: Norbert Luksa <norbert.lu...@cloudera.com> Gerrit-Reviewer: Anonymous Coward (520) Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Norbert Luksa <norbert.lu...@cloudera.com> Gerrit-Reviewer: Qifan Chen <qc...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Comment-Date: Thu, 26 Aug 2021 02:33:47 +0000 Gerrit-HasComments: Yes
