Qifan Chen has posted comments on this change. ( http://gerrit.cloudera.org:8080/15403 )
Change subject: IMPALA-6505: Min-Max predicate push down in ORC scanner ...................................................................... Patch Set 7: (1 comment) | But I think we do need to improve observability on the final predicates that are pushed down. E.g. "x = 1" is currently transformed into "x <= 1" and "x >= 1" but it's not shown in the plan. It may be possible for FE to go over the min/max predicates and output, as "orc pushdown predicates" in the explain string, those that can be translated into ORC push-down predicates by BE. http://gerrit.cloudera.org:8080/#/c/15403/5/fe/src/main/java/org/apache/impala/planner/HdfsScanNode.java File fe/src/main/java/org/apache/impala/planner/HdfsScanNode.java: http://gerrit.cloudera.org:8080/#/c/15403/5/fe/src/main/java/org/apache/impala/planner/HdfsScanNode.java@1842 PS5, Line 1842: if (hasParquet(fileFormats_) && fileFormats_.contains(HdfsFileFormat.ORC) > Yeah, each partition can have its own format. But it's rarely used. Docs: Good to know. Thanks for the link. -- To view, visit http://gerrit.cloudera.org:8080/15403 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I136622413db21e0941d238ab6aeea901a6464845 Gerrit-Change-Number: 15403 Gerrit-PatchSet: 7 Gerrit-Owner: Norbert Luksa <norbert.lu...@cloudera.com> Gerrit-Reviewer: Anonymous Coward (520) Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Norbert Luksa <norbert.lu...@cloudera.com> Gerrit-Reviewer: Qifan Chen <qc...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Comment-Date: Thu, 26 Aug 2021 16:07:36 +0000 Gerrit-HasComments: Yes
