Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17818 )
Change subject: cleaner and faster operations wtih datasketches ...................................................................... Patch Set 1: (22 comments) http://gerrit.cloudera.org:8080/#/c/17818/1/be/src/exprs/aggregate-functions-ir.cc File be/src/exprs/aggregate-functions-ir.cc: http://gerrit.cloudera.org:8080/#/c/17818/1/be/src/exprs/aggregate-functions-ir.cc@2089 PS1, Line 2089: dst_union_ptr->update(datasketches::compact_theta_sketch::deserialize(src.ptr, src.len)); line too long (95 > 90) http://gerrit.cloudera.org:8080/#/c/17818/1/be/src/exprs/aggregate-functions-ir.cc@2100 PS1, Line 2100: union_sketch.update(datasketches::compact_theta_sketch::deserialize(src.ptr, src.len)); line too long (93 > 90) http://gerrit.cloudera.org:8080/#/c/17818/1/be/src/exprs/datasketches-common.cc File be/src/exprs/datasketches-common.cc: http://gerrit.cloudera.org:8080/#/c/17818/1/be/src/exprs/datasketches-common.cc@39 PS1, Line 39: ctx->SetError(strings::Substitute("Unable to deserialize sketch: $0", e.what()).c_str()); line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/17818/1/be/src/exprs/datasketches-common.cc@53 PS1, Line 53: union_sketch.update(datasketches::cpc_sketch::deserialize(serialized_sketch.ptr, serialized_sketch.len)); line too long (111 > 90) http://gerrit.cloudera.org:8080/#/c/17818/1/be/src/exprs/datasketches-common.cc@66 PS1, Line 66: sketch.update(datasketches::compact_theta_sketch::deserialize(serialized_sketch.ptr, serialized_sketch.len)); line too long (115 > 90) http://gerrit.cloudera.org:8080/#/c/17818/1/be/src/exprs/datasketches-common.cc@79 PS1, Line 79: sketch.update(datasketches::compact_theta_sketch::deserialize(serialized_sketch.ptr, serialized_sketch.len)); line too long (115 > 90) http://gerrit.cloudera.org:8080/#/c/17818/1/be/src/exprs/datasketches-functions-ir.cc File be/src/exprs/datasketches-functions-ir.cc: http://gerrit.cloudera.org:8080/#/c/17818/1/be/src/exprs/datasketches-functions-ir.cc@40 PS1, Line 40: auto sketch = datasketches::hll_sketch::deserialize(serialized_sketch.ptr, serialized_sketch.len); line too long (102 > 90) http://gerrit.cloudera.org:8080/#/c/17818/1/be/src/exprs/datasketches-functions-ir.cc@62 PS1, Line 62: auto sketch = datasketches::hll_sketch::deserialize(serialized_sketch.ptr, serialized_sketch.len); line too long (102 > 90) http://gerrit.cloudera.org:8080/#/c/17818/1/be/src/exprs/datasketches-functions-ir.cc@78 PS1, Line 78: union_sketch.update(datasketches::hll_sketch::deserialize(serialized_sketch1.ptr, serialized_sketch1.len)); line too long (113 > 90) http://gerrit.cloudera.org:8080/#/c/17818/1/be/src/exprs/datasketches-functions-ir.cc@86 PS1, Line 86: union_sketch.update(datasketches::hll_sketch::deserialize(serialized_sketch2.ptr, serialized_sketch2.len)); line too long (113 > 90) http://gerrit.cloudera.org:8080/#/c/17818/1/be/src/exprs/datasketches-functions-ir.cc@102 PS1, Line 102: auto sketch = datasketches::hll_sketch::deserialize(serialized_sketch.ptr, serialized_sketch.len); line too long (102 > 90) http://gerrit.cloudera.org:8080/#/c/17818/1/be/src/exprs/datasketches-functions-ir.cc@117 PS1, Line 117: auto sketch = datasketches::cpc_sketch::deserialize(serialized_sketch.ptr, serialized_sketch.len); line too long (102 > 90) http://gerrit.cloudera.org:8080/#/c/17818/1/be/src/exprs/datasketches-functions-ir.cc@129 PS1, Line 129: auto sketch = datasketches::cpc_sketch::deserialize(serialized_sketch.ptr, serialized_sketch.len); line too long (102 > 90) http://gerrit.cloudera.org:8080/#/c/17818/1/be/src/exprs/datasketches-functions-ir.cc@160 PS1, Line 160: auto sketch = datasketches::compact_theta_sketch::deserialize(serialized_sketch.ptr, serialized_sketch.len); line too long (112 > 90) http://gerrit.cloudera.org:8080/#/c/17818/1/be/src/exprs/datasketches-functions-ir.cc@182 PS1, Line 182: datasketches::compact_theta_sketch::deserialize(serialized_sketch1.ptr, serialized_sketch1.len), line too long (104 > 90) http://gerrit.cloudera.org:8080/#/c/17818/1/be/src/exprs/datasketches-functions-ir.cc@183 PS1, Line 183: datasketches::compact_theta_sketch::deserialize(serialized_sketch2.ptr, serialized_sketch2.len) line too long (103 > 90) http://gerrit.cloudera.org:8080/#/c/17818/1/be/src/exprs/datasketches-functions-ir.cc@238 PS1, Line 238: auto sketch = datasketches::kll_sketch<float>::deserialize(serialized_sketch.ptr, serialized_sketch.len); line too long (109 > 90) http://gerrit.cloudera.org:8080/#/c/17818/1/be/src/exprs/datasketches-functions-ir.cc@251 PS1, Line 251: auto sketch = datasketches::kll_sketch<float>::deserialize(serialized_sketch.ptr, serialized_sketch.len); line too long (109 > 90) http://gerrit.cloudera.org:8080/#/c/17818/1/be/src/exprs/datasketches-functions-ir.cc@263 PS1, Line 263: auto sketch = datasketches::kll_sketch<float>::deserialize(serialized_sketch.ptr, serialized_sketch.len); line too long (109 > 90) http://gerrit.cloudera.org:8080/#/c/17818/1/be/src/exprs/datasketches-functions-ir.cc@278 PS1, Line 278: auto sketch = datasketches::kll_sketch<float>::deserialize(serialized_sketch.ptr, serialized_sketch.len); line too long (109 > 90) http://gerrit.cloudera.org:8080/#/c/17818/1/be/src/exprs/datasketches-functions-ir.cc@298 PS1, Line 298: auto sketch = datasketches::kll_sketch<float>::deserialize(serialized_sketch.ptr, serialized_sketch.len); line too long (109 > 90) http://gerrit.cloudera.org:8080/#/c/17818/1/be/src/exprs/datasketches-functions-ir.cc@326 PS1, Line 326: auto sketch = datasketches::kll_sketch<float>::deserialize(serialized_sketch.ptr, serialized_sketch.len); line too long (109 > 90) -- To view, visit http://gerrit.cloudera.org:8080/17818 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I306a2489dac0f4d2d475e8f9987cd58bf95474bb Gerrit-Change-Number: 17818 Gerrit-PatchSet: 1 Gerrit-Owner: Alexander Saydakov <al...@apache.org> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Comment-Date: Tue, 31 Aug 2021 00:11:59 +0000 Gerrit-HasComments: Yes
