Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/17818 )
Change subject: cleaner and faster operations wtih datasketches ...................................................................... Patch Set 1: (4 comments) Thanks Alexander for taking care of these changes! Apart from the automated format checks I left some comments, nothing serious. http://gerrit.cloudera.org:8080/#/c/17818/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/17818/1//COMMIT_MSG@7 PS1, Line 7: cleaner I've created a jira ticket for this patch. Could you please add the Jira Id to the beginning of the commit msg (similarly to other patches)? https://issues.apache.org/jira/browse/IMPALA-10901 http://gerrit.cloudera.org:8080/#/c/17818/1//COMMIT_MSG@7 PS1, Line 7: wtih typo http://gerrit.cloudera.org:8080/#/c/17818/1//COMMIT_MSG@8 PS1, Line 8: Could you please write a sentence or two here to sum up the changes in this patch? http://gerrit.cloudera.org:8080/#/c/17818/1/be/src/exprs/aggregate-functions-ir.cc File be/src/exprs/aggregate-functions-ir.cc: http://gerrit.cloudera.org:8080/#/c/17818/1/be/src/exprs/aggregate-functions-ir.cc@1624 PS1, Line 1624: StringVal SerializeCompactDsHllSketch(FunctionContext* ctx, With this simplification we ended up with a number of functions that have actually the same body, and a difference between them is a function parameter. I wonder if these could be simplified further to have a single template function that covers all of them. -- To view, visit http://gerrit.cloudera.org:8080/17818 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I306a2489dac0f4d2d475e8f9987cd58bf95474bb Gerrit-Change-Number: 17818 Gerrit-PatchSet: 1 Gerrit-Owner: Alexander Saydakov <al...@apache.org> Gerrit-Reviewer: Gabor Kaszab <gaborkas...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Comment-Date: Tue, 31 Aug 2021 07:33:07 +0000 Gerrit-HasComments: Yes
