Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/17853 )
Change subject: IMPALA-10714: Defer advancing read page until the buffer is attached ...................................................................... Patch Set 3: (3 comments) Thank you for the feedback! After expanding the test case, I found that fix from patch set 2 is still incorrect. Delayed advancement of read page should only allowed in read-write stream. Patch set 3 add checks for 'has_write_iterator_' to make sure that the stream is indeed a read-write stream. http://gerrit.cloudera.org:8080/#/c/17853/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/17853/2//COMMIT_MSG@10 PS2, Line 10: Stream > nit. expects Done http://gerrit.cloudera.org:8080/#/c/17853/2/be/src/runtime/buffered-tuple-stream-test.cc File be/src/runtime/buffered-tuple-stream-test.cc: http://gerrit.cloudera.org:8080/#/c/17853/2/be/src/runtime/buffered-tuple-stream-test.cc@1388 PS2, Line 1388: eservation to alloc > May need to add the following additional test cases This is now addressed by: 1. TestUnpinAfterFullStreamRead(num_rows, buffer_size, max_num_pages, false, true, false); 2. TestUnpinAfterFullStreamRead(num_rows, buffer_size, max_num_pages, true, false, ...); http://gerrit.cloudera.org:8080/#/c/17853/2/be/src/runtime/buffered-tuple-stream-test.cc@1397 PS2, Line 1397: > May need to test #pages == 1. I believe this is now addressed by TestUnpinAfterFullStreamRead with attach_on_read=true and refill_before_unpin=false. With this argument, the stream only have 1 page left before UnpinStream() is called. -- To view, visit http://gerrit.cloudera.org:8080/17853 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I586ed72ba01cc3f28b0dcb1e202b3ca32a6c3b83 Gerrit-Change-Number: 17853 Gerrit-PatchSet: 3 Gerrit-Owner: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Qifan Chen <qc...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Comment-Date: Tue, 21 Sep 2021 17:40:44 +0000 Gerrit-HasComments: Yes
