Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/17853 )
Change subject: IMPALA-10714: Defer advancing read page until the buffer is attached ...................................................................... Patch Set 4: Code-Review+2 (1 comment) The fix makes sense to me. Thanks for digging into this! Carrying Qifan's +1 and mine to +2. http://gerrit.cloudera.org:8080/#/c/17853/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/17853/3//COMMIT_MSG@12 PS3, Line 12: However, BufferedTupleStream::GetNextInternal() will not : attach the page buffer of a fully read page if it is a read-write page. : > I describe the scenario that lead to the assertion failure in patch set 4. I see. Thanks for adding more details! -- To view, visit http://gerrit.cloudera.org:8080/17853 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I586ed72ba01cc3f28b0dcb1e202b3ca32a6c3b83 Gerrit-Change-Number: 17853 Gerrit-PatchSet: 4 Gerrit-Owner: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Qifan Chen <qc...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Comment-Date: Thu, 23 Sep 2021 12:32:33 +0000 Gerrit-HasComments: Yes
