Riza Suminto has uploaded this change for review. ( http://gerrit.cloudera.org:8080/17894
Change subject: IMPALA-10950: Update expr-benchmark.cc ...................................................................... IMPALA-10950: Update expr-benchmark.cc Query planner has move the scalar expression's thrift definition from 'fragments[0].output_sink.output_exprs' to 'fragments[0].plan.nodes[0].union_node.const_expr_lists[0]'. This patch adjust expr-benchmark.cc to generate the ScalarExpr from the right thrift location and also modify the helper class to ensure proper resource cleanup at the end of benchmark. The benchmark used to be run without codegen. However, some expressions in the benchmark now will crash without codegen due to missing symbols. Those expressions include cast to decimal, asin, acos, and parse_url for PROTOCOL. Therefore, this patch enables codegen for all expressions being benchmarked. Testing: - Run and verify that expr-benchmark does not crash. Change-Id: I5b17434d85e32a58622bffb64a697b062a8bf43f --- M be/src/benchmarks/expr-benchmark.cc 1 file changed, 128 insertions(+), 85 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/94/17894/1 -- To view, visit http://gerrit.cloudera.org:8080/17894 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I5b17434d85e32a58622bffb64a697b062a8bf43f Gerrit-Change-Number: 17894 Gerrit-PatchSet: 1 Gerrit-Owner: Riza Suminto <riza.sumi...@cloudera.com>
