Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/17894 )
Change subject: IMPALA-10950: Update expr-benchmark.cc ...................................................................... Patch Set 3: (1 comment) Hi Bikram, thank you for your review. Unfortunately, I just found one big problem in my patch. http://gerrit.cloudera.org:8080/#/c/17894/3/be/src/benchmarks/expr-benchmark.cc File be/src/benchmarks/expr-benchmark.cc: http://gerrit.cloudera.org:8080/#/c/17894/3/be/src/benchmarks/expr-benchmark.cc@108 PS3, Line 108: const TQueryExecRequest& query_request = request.query_exec_request; > nit: might be worth adding context here about the kind of plan created for This one seems to be a bigger obstacle for benchmarking expression. I take a closer looks and it seems the Planner rewrite most of constant query in this benchmark into literal expression through FoldConstantsRule https://github.com/apache/impala/blob/master/fe/src/main/java/org/apache/impala/rewrite/FoldConstantsRule.java For example, "select 1+1;" will be rewritten into "select 2;", and "select from_unixtime(0, 'yyyy-MM-dd');" will be rewritten into "select '1970-01-01';". I'll look around if we can disable this rewrite rule just for this benchmarking purpose. Otherwise, the benchmark does not make sense in the current state. -- To view, visit http://gerrit.cloudera.org:8080/17894 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5b17434d85e32a58622bffb64a697b062a8bf43f Gerrit-Change-Number: 17894 Gerrit-PatchSet: 3 Gerrit-Owner: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Reviewer: Bikramjeet Vig <bikramjeet....@cloudera.com> Gerrit-Reviewer: Gabor Kaszab <gaborkas...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Comment-Date: Tue, 05 Oct 2021 18:36:21 +0000 Gerrit-HasComments: Yes
